From: David Miller <davem@davemloft.net>
To: gregory.v.rose@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: Fix problem with buffer allocation
Date: Tue, 21 Feb 2012 16:21:25 -0500 (EST) [thread overview]
Message-ID: <20120221.162125.1533105883101299190.davem@davemloft.net> (raw)
In-Reply-To: <20120221.161630.1122203779408129070.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 21 Feb 2012 16:16:30 -0500 (EST)
>
> Greg, where is the code that guards the actual dumping of the VF
> information based upon the ext mask?
>
> I only see the ext mask controlling the sizing of the SKB. What good
> is that if we still dump the VFs?
Actually, it's even worse, this thing doesn't even compile because
you haven't updated the actual implementation of rtnl_vfinfo_size()
to take the new mask argument.
You didn't even compile test this, are you fucking kidding me?
net/core/rtnetlink.c: In function ‘if_nlmsg_size’:
net/core/rtnetlink.c:789:9: error: too many arguments to function ‘rtnl_vfinfo_size’
net/core/rtnetlink.c:726:19: note: declared here
make[1]: *** [net/core/rtnetlink.o] Error 1
make: *** [net/core/rtnetlink.o] Error 2
next prev parent reply other threads:[~2012-02-21 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 20:47 [PATCH] rtnetlink: Fix problem with buffer allocation Greg Rose
2012-02-21 21:16 ` David Miller
2012-02-21 21:21 ` David Miller [this message]
2012-02-21 21:28 ` Rose, Gregory V
2012-02-21 21:32 ` David Miller
2012-02-21 21:33 ` Rose, Gregory V
2012-02-21 21:41 ` Rose, Gregory V
2012-02-21 21:48 ` Eric Dumazet
2012-02-21 21:50 ` David Miller
2012-02-21 21:56 ` Rose, Gregory V
2012-02-21 22:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221.162125.1533105883101299190.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).