* [PATCH] jme: Fix FIFO flush issue
@ 2012-02-22 18:58 Guo-Fu Tseng
2012-02-22 20:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Guo-Fu Tseng @ 2012-02-22 18:58 UTC (permalink / raw)
To: David Miller
Cc: Guo-Fu Tseng, linux-netdev, Steven Chen, Devinchiu, angelli,
Federico Quagliata, stable
From: Guo-Fu Tseng <cooldavid@cooldavid.org>
Set the RX FIFO flush watermark lower.
According to Federico and JMicron's reply,
setting it to 16QW would be stable on most platforms.
Otherwise, user might experience packet drop issue.
CC: stable@kernel.org
Reported-by: Federico Quagliata <federico@quagliata.org>
Fixed-by: Federico Quagliata <federico@quagliata.org>
Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
---
drivers/net/ethernet/jme.c | 10 +---------
drivers/net/ethernet/jme.h | 2 +-
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 1b86d0b..4ea6580 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -2328,19 +2328,11 @@ jme_change_mtu(struct net_device *netdev, int new_mtu)
((new_mtu) < IPV6_MIN_MTU))
return -EINVAL;
- if (new_mtu > 4000) {
- jme->reg_rxcs &= ~RXCS_FIFOTHNP;
- jme->reg_rxcs |= RXCS_FIFOTHNP_64QW;
- jme_restart_rx_engine(jme);
- } else {
- jme->reg_rxcs &= ~RXCS_FIFOTHNP;
- jme->reg_rxcs |= RXCS_FIFOTHNP_128QW;
- jme_restart_rx_engine(jme);
- }
netdev->mtu = new_mtu;
netdev_update_features(netdev);
+ jme_restart_rx_engine(jme);
jme_reset_link(jme);
return 0;
diff --git a/drivers/net/ethernet/jme.h b/drivers/net/ethernet/jme.h
index 4304072..3efc897 100644
--- a/drivers/net/ethernet/jme.h
+++ b/drivers/net/ethernet/jme.h
@@ -730,7 +730,7 @@ enum jme_rxcs_values {
RXCS_RETRYCNT_60 = 0x00000F00,
RXCS_DEFAULT = RXCS_FIFOTHTP_128T |
- RXCS_FIFOTHNP_128QW |
+ RXCS_FIFOTHNP_16QW |
RXCS_DMAREQSZ_128B |
RXCS_RETRYGAP_256ns |
RXCS_RETRYCNT_32,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jme: Fix FIFO flush issue
2012-02-22 18:58 [PATCH] jme: Fix FIFO flush issue Guo-Fu Tseng
@ 2012-02-22 20:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-02-22 20:26 UTC (permalink / raw)
To: cooldavid; +Cc: netdev, stevenchen, devinchiu, angelli, federico, stable
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Thu, 23 Feb 2012 02:58:10 +0800
> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> Set the RX FIFO flush watermark lower.
> According to Federico and JMicron's reply,
> setting it to 16QW would be stable on most platforms.
> Otherwise, user might experience packet drop issue.
>
> CC: stable@kernel.org
> Reported-by: Federico Quagliata <federico@quagliata.org>
> Fixed-by: Federico Quagliata <federico@quagliata.org>
> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-22 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-22 18:58 [PATCH] jme: Fix FIFO flush issue Guo-Fu Tseng
2012-02-22 20:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).