From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] mlx4_en: moderate frequency of TX completions
Date: Thu, 23 Feb 2012 14:44:37 -0500 (EST) [thread overview]
Message-ID: <20120223.144437.32389814881687535.davem@davemloft.net> (raw)
In-Reply-To: <4F464063.1010001@mellanox.co.il>
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Thu, 23 Feb 2012 15:34:27 +0200
> No need to ask for completion for every packet being sent.
> So the method is to ask for a completion every 16 packets,
> or when the queue is about to be full.
>
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
You absolutely cannot do this, you must signal completion and free up
TX queue packets in a finite amount of time.
This means that if you suddenly stop getting new packets to send
you must still free up all the pending TX SKBs even if no more
packets are given to the driver.
Does your hardware unconditionally give a TX completion interrupt when
the TX queue empties completely? If not, then you cannot make the
change contained in this patch.
next prev parent reply other threads:[~2012-02-23 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:34 [PATCH net-next 2/3] mlx4_en: moderate frequency of TX completions Yevgeny Petrilin
2012-02-23 19:44 ` David Miller [this message]
2012-02-23 21:13 ` Ben Hutchings
2012-02-23 21:26 ` Ben Hutchings
2012-02-23 21:47 ` David Miller
2012-02-23 21:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223.144437.32389814881687535.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).