From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] mlx4_en: Saving mem access on data path
Date: Thu, 23 Feb 2012 14:47:49 -0500 (EST) [thread overview]
Message-ID: <20120223.144749.1718133820851859801.davem@davemloft.net> (raw)
In-Reply-To: <4F464074.9050901@mellanox.co.il>
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Thu, 23 Feb 2012 15:34:44 +0200
>
> Localized the pdev->dev, and using dma_map instead of pci_map
> There are multiple map/unmap operations on data path,
> optimizing those by saving redundant pointer access.
>
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
I doubt you can measure any improvement from this at all, all of the
real cost is going to be in programming the hardware (both the
networking chip and potentially any IOMMU hardware to setup the DMA
mappings). A pointer deref in of your datastructures will be
unnoticable.
When you make changes like this I want you to justify them with real
data and facts.
I think this entire patch set was in very poor taste and judgment.
next prev parent reply other threads:[~2012-02-23 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:34 [PATCH net-next 3/3] mlx4_en: Saving mem access on data path Yevgeny Petrilin
2012-02-23 19:47 ` David Miller [this message]
2012-02-24 19:57 ` Yevgeny Petrilin
2012-03-01 13:03 ` Or Gerlitz
2012-03-01 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223.144749.1718133820851859801.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).