From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: darkbasic@linuxsystems.it, netdev@vger.kernel.org,
openadsl-users@lists.sourceforge.net,
openadsl-devel@lists.sourceforge.net, 660804@bugs.debian.org,
support@traverse.com.au, support@rocksolidelectronics.com
Subject: Re: [Bug 42809] New: kernel panic when receiving an ipsec packet
Date: Thu, 23 Feb 2012 15:23:14 -0500 (EST) [thread overview]
Message-ID: <20120223.152314.1111200746248162115.davem@davemloft.net> (raw)
In-Reply-To: <1330028243.15610.40.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 23 Feb 2012 21:17:23 +0100
> Le jeudi 23 février 2012 à 15:11 -0500, David Miller a écrit :
>> Three instances of the same piece of code, maybe a helper function is
>> appropriate at that point? :-) You might even get ambitious and add a
>> big comment to that helper function explaining the situation.
>
> I did have this idea but refrained because this kind of things is harder
> to backport to stable kernels.
>
> I'll make a cleanup in net-next if you agree ?
I think the work to backport is equal whether you use a helper function
or not. Heck, use an inline function so you don't have to worry about
module exports or any details like that.
Besides, I'm the one who likely has to backport this thing, so... :-)
next prev parent reply other threads:[~2012-02-23 20:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-42809-100@https.bugzilla.kernel.org/>
2012-02-22 17:20 ` [Bug 42809] New: kernel panic when receiving an ipsec packet Stephen Hemminger
2012-02-22 17:41 ` Niccolò Belli
2012-02-23 0:59 ` Niccolò Belli
2012-02-23 1:38 ` Eric Dumazet
2012-02-23 1:46 ` [openadsl-users] " Jason White
2012-02-23 1:54 ` Eric Dumazet
2012-02-23 13:48 ` Bug#660804: " chas williams - CONTRACTOR
2012-02-23 1:55 ` Niccolò Belli
2012-02-23 2:02 ` Niccolò Belli
2012-02-23 2:06 ` Eric Dumazet
2012-02-23 2:12 ` Niccolò Belli
2012-02-23 13:45 ` Niccolò Belli
2012-02-23 14:36 ` Eric Dumazet
2012-02-23 14:39 ` Eric Dumazet
2012-02-23 19:08 ` Niccolò Belli
2012-02-23 20:11 ` David Miller
2012-02-23 20:17 ` Eric Dumazet
2012-02-23 20:23 ` David Miller [this message]
2012-02-23 20:28 ` Eric Dumazet
2012-02-23 20:55 ` [PATCH V2] ipsec: be careful of non existing mac headers Eric Dumazet
2012-02-23 21:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223.152314.1111200746248162115.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=660804@bugs.debian.org \
--cc=darkbasic@linuxsystems.it \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openadsl-devel@lists.sourceforge.net \
--cc=openadsl-users@lists.sourceforge.net \
--cc=support@rocksolidelectronics.com \
--cc=support@traverse.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).