From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ppp: fix 'ppp_mp_reconstruct bad seq' errors Date: Fri, 24 Feb 2012 17:52:30 -0500 (EST) Message-ID: <20120224.175230.2288284076227953420.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: paulus@samba.org, netdev@vger.kernel.org, linux-ppp@vger.kernel.org To: ben@netservers.co.uk Return-path: In-Reply-To: Sender: linux-ppp-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Ben McKeegan Date: Fri, 24 Feb 2012 16:33:56 +0000 (GMT) > > This patch fixes a (mostly cosmetic) bug introduced by the patch > 'ppp: Use SKB queue abstraction interfaces in fragment processing' > found here: http://www.spinics.net/lists/netdev/msg153312.html > > The above patch rewrote and moved the code responsible for cleaning > up discarded fragments but the new code does not catch every case > where this is necessary. This results in some discarded fragments > remaining in the queue, and triggering a 'bad seq' error on the > subsequent call to ppp_mp_reconstruct. Fragments are discarded > whenever other fragments of the same frame have been lost. > This can generate a lot of unwanted and misleading log messages. > > This patch also adds additional detail to the debug logging to > make it clearer which fragments were lost and which other fragments > were discarded as a result of losses. (Run pppd with 'kdebug 1' > option to enable debug logging.) > > Signed-off-by: Ben McKeegan I'll apply this, thanks.