From: David Miller <davem@davemloft.net>
To: eugenia@mellanox.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, yevgenyp@mellanox.com
Subject: Re: [PATCH net-next] mlx4_en: dont change mac_header on xmit
Date: Sun, 26 Feb 2012 14:27:23 -0500 (EST) [thread overview]
Message-ID: <20120226.142723.2089903339861181922.davem@davemloft.net> (raw)
In-Reply-To: <74A0102445410646AFACC089FD94803A616DC2FE@MTLDAG02.mtl.com>
From: Eugenia Emantayev <eugenia@mellanox.com>
Date: Sun, 26 Feb 2012 19:12:12 +0000
> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
> Sent: Saturday, February 25, 2012 12:51 PM
>
>> A driver xmit function is not allowed to change skb without special
>> care.
>>
>> mlx4_en_xmit() should not call skb_reset_mac_header() and instead should
>> use skb->data to access ethernet header.
>>
>> This removes a dumb test : if (ethh && ethh->h_dest)
>>
>> Also remove this slow mlx4_en_mac_to_u64() call, we can use
>> get_unaligned() to get faster code.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>> Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
>> ---
>> Please test this patch before we can commit it, thanks !
>
> Tested and approved, thanks.
> --
Applied.
next prev parent reply other threads:[~2012-02-26 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <953B660C027164448AE903364AC447D2618B88E7@MTLDAG02.mtl.com>
2012-02-26 19:12 ` [PATCH net-next] mlx4_en: dont change mac_header on xmit Eugenia Emantayev
2012-02-26 19:27 ` David Miller [this message]
2012-02-25 10:51 Eric Dumazet
2012-03-04 11:19 ` Or Gerlitz
2012-03-04 15:56 ` Eric Dumazet
2012-03-04 20:02 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120226.142723.2089903339861181922.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=eugenia@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).