* [PATCH net-next] gigaset: Use semicolons to terminate statements [not found] ` <1330363627.9942.16.camel@joe2Laptop> @ 2012-02-27 17:39 ` Joe Perches 2012-02-27 19:12 ` David Miller 0 siblings, 1 reply; 2+ messages in thread From: Joe Perches @ 2012-02-27 17:39 UTC (permalink / raw) To: Jiri Slaby, netdev, Karsten Keil Cc: Jiri Slaby, LKML, Hansjoerg Lipp, Tilman Schmidt, gigaset307x-common, David Miller Commas are not generally used at locations where statement termination semicolons are used. Realign each field set at appropriate indentation. Signed-off-by: Joe Perches <joe@perches.com> --- diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index da2486e..91f99e4 100644 @@ -679,10 +679,10 @@ void gigaset_if_initdriver(struct gigaset_driver *drv, const char *procname, if (tty == NULL) goto enomem; - tty->magic = TTY_DRIVER_MAGIC, - tty->type = TTY_DRIVER_TYPE_SERIAL, - tty->subtype = SERIAL_TYPE_NORMAL, - tty->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV; + tty->magic = TTY_DRIVER_MAGIC; + tty->type = TTY_DRIVER_TYPE_SERIAL; + tty->subtype = SERIAL_TYPE_NORMAL; + tty->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV; tty->driver_name = procname; tty->name = devname; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] gigaset: Use semicolons to terminate statements 2012-02-27 17:39 ` [PATCH net-next] gigaset: Use semicolons to terminate statements Joe Perches @ 2012-02-27 19:12 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2012-02-27 19:12 UTC (permalink / raw) To: joe Cc: jslaby, netdev, isdn, jirislaby, linux-kernel, hjlipp, tilman, gigaset307x-common From: Joe Perches <joe@perches.com> Date: Mon, 27 Feb 2012 09:39:27 -0800 > Commas are not generally used at locations where > statement termination semicolons are used. > > Realign each field set at appropriate indentation. > > Signed-off-by: Joe Perches <joe@perches.com> Applied, thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-27 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4F4B45F6.4090706@suse.cz>
[not found] ` <1330361549.9942.7.camel@joe2Laptop>
[not found] ` <4F4BB983.8020608@suse.cz>
[not found] ` <1330363627.9942.16.camel@joe2Laptop>
2012-02-27 17:39 ` [PATCH net-next] gigaset: Use semicolons to terminate statements Joe Perches
2012-02-27 19:12 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).