From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] tcp: fix tcp_shifted_skb() adjustment of lost_cnt_hint for FACK Date: Mon, 27 Feb 2012 23:31:05 -0500 (EST) Message-ID: <20120227.233105.919773668237455042.davem@davemloft.net> References: <20120227.215820.1289745868005567561.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ilpo.jarvinen@helsinki.fi, gregkh@linuxfoundation.org, netdev@vger.kernel.org, nanditad@google.com, ycheng@google.com, therbert@google.com, subramanian.vijay@gmail.com To: ncardwell@google.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:41005 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753951Ab2B1EbW (ORCPT ); Mon, 27 Feb 2012 23:31:22 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Neal Cardwell Date: Mon, 27 Feb 2012 22:45:31 -0500 > On Mon, Feb 27, 2012 at 9:58 PM, David Miller wrote: >> From: Neal Cardwell >> Date: Mon, 27 Feb 2012 21:40:03 -0500 >> >>> Yes, I agree that it would make sense to hold off on adding these >>> three 3.3-rc4 commits to the stable tree: >>> >>> cc9a672ee522d4805495b98680f4a3db5d0a0af9 >>> >>> daef52bab1fd26e24e8e9578f8fb33ba1d0cb412 >>> >>> 0af2a0d0576205dda778d25c6c344fc6508fc81d >>> >>> It would make sense to let the dust settle a bit more before adding >>> those to the stable tree. >>> >>> The same goes for the http://patchwork.ozlabs.org/patch/143114/ patch >>> (under review) that is in the same area of the code. >> >> I totally disagree and I have submitted those fixes to -stable >> already and do not plan to rescind those submissions at all. > > OK, sounds good to me. In that case I think it would be good to have > the http://patchwork.ozlabs.org/patch/143114/ patch in -stable as > well, since having just the three patches above would leave us with a > known reordering issue. I'll make sure it hits the -stable release after the one Greg is trying to put out right now. The change you reference rarely matters as most of the time it passes a degreee of reordering of one.