From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <benh@kernel.crashing.org>,
<linuxppc-dev@lists.ozlabs.org>, <jwboyer@gmail.com>,
<mporter@kernel.crashing.org>
Subject: Re: [PATCH net-next] ibm emac: delete module references; phy.c only supported as built-in
Date: Mon, 27 Feb 2012 15:49:42 -0500 [thread overview]
Message-ID: <20120227204941.GA29529@windriver.com> (raw)
In-Reply-To: <20120227.145753.1111293673513137413.davem@davemloft.net>
[Re: [PATCH net-next] ibm emac: delete module references; phy.c only supported as built-in] On 27/02/2012 (Mon 14:57) David Miller wrote:
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date: Mon, 27 Feb 2012 14:47:04 -0500
>
> > The Makefile has it as "ibm_emac-y := mal.o core.o phy.o" so there is
> > no way this can be built modular, so remove all references to module
> > support.
>
> That doesn't mean it's only buildable statically.
>
> "ibm_emacs-y :=" is merely a way to tell make what objects go into ibm_emac.{o,ko}
>
> IBM_EMAC is tristate
Argh, yes. Sorry for the noise. Since phy.c doesn't call any modular
functionality directly, the patch "worked" and I didn't catch the
error in my reasoning.
Paul.
prev parent reply other threads:[~2012-02-27 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 19:47 [PATCH net-next] ibm emac: delete module references; phy.c only supported as built-in Paul Gortmaker
2012-02-27 19:56 ` Ben Hutchings
2012-02-27 19:57 ` David Miller
2012-02-27 20:49 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227204941.GA29529@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=jwboyer@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mporter@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).