netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 03/13] mac802154: RX data path
Date: Tue, 28 Feb 2012 15:22:13 -0500 (EST)	[thread overview]
Message-ID: <20120228.152213.1300224068127558485.davem@davemloft.net> (raw)
In-Reply-To: <1330441232-17650-4-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

From: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Tue, 28 Feb 2012 18:00:22 +0300

> Main RX data path implementation between physical and mac layers.
> Both contexts are supported: interrupt (data processed via worker)
> and non-interrupt (data processed directly).
> 
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

If packets are properly pushed into the stack via the core receive
packet processing of the networking, you should always be in softirq
context and therefore have no need to a workqueue to get out of hardirq
context.

Please redo this code so that it processes RX packets properly and
consistently with how other protocol layers do things, which is taking
packets from the netif_receive_skb() et al. paths via core protocol
demux and therefore running always in softirq context.

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d

  parent reply	other threads:[~2012-02-28 20:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 15:00 [PATCH 0/13 v3] basic IEEE 802.15.4 MAC support Alexander Smirnov
2012-02-28 15:00 ` [PATCH 01/13] mac802154: basic ieee802.15.4 device structures Alexander Smirnov
2012-02-28 15:00 ` [PATCH 02/13] mac802154: allocation of ieee802154 device Alexander Smirnov
2012-02-28 15:00 ` [PATCH 03/13] mac802154: RX data path Alexander Smirnov
     [not found]   ` <1330441232-17650-4-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-28 20:22     ` David Miller [this message]
     [not found] ` <1330441232-17650-1-git-send-email-alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-28 15:00   ` [PATCH 04/13] mac802154: TX " Alexander Smirnov
2012-02-28 15:00   ` [PATCH 05/13] mac802154: define reduced mlme operations Alexander Smirnov
2012-02-28 15:00   ` [PATCH 06/13] mac802154: slave interfaces definition Alexander Smirnov
2012-02-28 15:00   ` [PATCH 07/13] mac802154: declare reduced mlme operations Alexander Smirnov
2012-02-28 15:00   ` [PATCH 08/13] mac802154: basic mib support Alexander Smirnov
2012-02-28 15:00   ` [PATCH 10/13] mac802154: slaves manipulation routine Alexander Smirnov
2012-02-28 15:00   ` [PATCH 11/13] mac802154: monitor device support Alexander Smirnov
2012-02-28 15:00   ` [PATCH 12/13] drivers/ieee802154: IEEE 802.15.4 loopback driver Alexander Smirnov
2012-02-28 15:00   ` [PATCH 13/13] Documentation/networking/ieee802154: update MAC chapter Alexander Smirnov
2012-02-28 15:00 ` [PATCH 09/13] ieee802154: interface type to be added Alexander Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228.152213.1300224068127558485.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).