From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] mdio: Export mdio.h to userland Date: Wed, 29 Feb 2012 18:02:42 -0500 (EST) Message-ID: <20120229.180242.197576747542301377.davem@davemloft.net> References: <1330542754.5881.4.camel@bwh-desktop> <20120229.154227.908693909825012701.davem@davemloft.net> <1330555428.5881.8.camel@bwh-desktop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com To: bhutchings@solarflare.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:34745 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756841Ab2B2XCr (ORCPT ); Wed, 29 Feb 2012 18:02:47 -0500 In-Reply-To: <1330555428.5881.8.camel@bwh-desktop> Sender: netdev-owner@vger.kernel.org List-ID: From: Ben Hutchings Date: Wed, 29 Feb 2012 22:43:48 +0000 > On Wed, 2012-02-29 at 15:42 -0500, David Miller wrote: >> From: Ben Hutchings >> Date: Wed, 29 Feb 2012 19:12:34 +0000 >> >> > On Wed, 2012-02-29 at 19:02 +0000, Ben Hutchings wrote: >> >> The ID packing/unpacking functions are needed by userland and the >> >> register definitions may also be useful there. >> > >> > Minor issue with this: mdio_phy_id_is_c45() returns bool, and that's not >> > defined by default. Should I add #include or change the >> > return type to int for maximum compatibility? >> >> I do not see any precedence for including stdbool.h in a kernel header >> file. And I sure as hell am not going to compromise using a correct >> type just to make this usable by userspace. >> >> I think this is of dubious value, and combined with the bool >> complication I'm not going to apply this, sorry. > > Without this, userland doing clause 45 MDIO has to duplicate the ID > packing definitions. Then come up with a real solution to the bool issue. But note that changing the bool to an int is not a solution, neither is #include unless we can reach consensus on lkml that this is OK.