From: Dan Carpenter <dan.carpenter@oracle.com>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: marcel@holtmann.org, padovan@profusion.mobi, davem@davemloft.net,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Silence static checker warning.
Date: Wed, 29 Feb 2012 22:16:06 +0300 [thread overview]
Message-ID: <20120229191605.GB22598@mwanda> (raw)
In-Reply-To: <1330535217-26785-1-git-send-email-santoshprasadnayak@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
On Wed, Feb 29, 2012 at 10:36:57PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Silencing Static checker warning.
> 1. Endian warning
It's not an endian warning, it's an endian bug. This code won't
work on big endian systems. Don't mix bugfixes and other changes.
Probably at some point someone will be updating their kernel for
an embedded platform and they'll do a "git log --pretty=oneline" and
they'll notice your endian fix and decide it's super important to
them. Right now it's hard to find.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-29 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 17:06 [PATCH] Bluetooth: Silence static checker warning santosh nayak
[not found] ` <1330535217-26785-1-git-send-email-santoshprasadnayak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-29 17:39 ` Marcel Holtmann
2012-02-29 17:46 ` Marcel Holtmann
2012-03-02 9:15 ` David Laight
2012-03-02 11:04 ` Dan Carpenter
2012-03-02 17:57 ` Marcel Holtmann
2012-02-29 19:16 ` Dan Carpenter [this message]
2012-02-29 20:45 ` Andrei Emeltchenko
[not found] ` <CAMXE1-oXtheVHDuU3w52mXqmuY8AK4kk+tuvJpVRDq2=+qEnsQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-01 5:37 ` santosh prasad nayak
2012-03-01 6:25 ` Dan Carpenter
2012-03-01 7:43 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229191605.GB22598@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).