From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: danny.kukawka@bisect.de, eilong@broadcom.com, dkukawka@suse.de,
eric.dumazet@gmail.com, mirq-linux@rere.qmqm.pl,
jpirko@redhat.com, nhorman@tuxdriver.com, rdunlap@xenotime.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] net: validate MAC address directly in dev_set_mac_address()
Date: Thu, 01 Mar 2012 16:21:30 -0500 (EST) [thread overview]
Message-ID: <20120301.162130.2267876784560089802.davem@davemloft.net> (raw)
In-Reply-To: <1330624289.2609.36.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 1 Mar 2012 17:51:29 +0000
> On Thu, 2012-03-01 at 17:52 +0100, Danny Kukawka wrote:
>> Validate the given MAC address directly in dev_set_mac_address()
>> if a .ndo_validate_addr function is available before calling
>> the .ndo_set_mac_address function.
>>
>> Changed .ndo_validate_addr to take a second parameter containing
>> a sockaddr struct to be checked instead of the net_device dev_addr.
>> The behaviour of .ndo_validate_addr is now: if the second parameter
>> is NULL the net_device->dev_addr gets validate, if != NULL
>> the given parameter/sockaddr gets validated instead.
> [...]
>
> The caller is assumed to have validated the address family, so why not
> just pass a pointer to the hardware address (u8 *), and get rid of the
> special case for NULL?
>
> That is, dev_set_mac_address would call:
> ops->ndo_validate_addr(dev, sa->sa_data);
> and dev_open would call:
> ops->ndo_validate_addr(dev, dev->dev_addr);
Yes, this looks a lot better.
next prev parent reply other threads:[~2012-03-01 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 16:52 [PATCH v2 0/7] validate MAC address before call .ndo_set_mac_address Danny Kukawka
2012-03-01 16:52 ` [PATCH v2 1/7] net: validate MAC address directly in dev_set_mac_address() Danny Kukawka
2012-03-01 17:51 ` Ben Hutchings
2012-03-01 21:21 ` David Miller [this message]
2012-03-01 16:52 ` [PATCH 2/7] cris/eth_v10: use dev_set_mac_address() instead of e100_set_mac_address() Danny Kukawka
2012-03-01 16:52 ` [PATCH 3/7] bcm63xx_enet: use dev_set_mac_address() instead of bcm_enet_set_mac_address() Danny Kukawka
2012-03-01 16:52 ` [PATCH 4/7] ethoc: add .ndo_validate_addr to net_device_ops Danny Kukawka
2012-03-01 16:52 ` [PATCH 5/7] lantiq_etop: use dev_set_mac_address() instead of ltq_etop_set_mac_address() Danny Kukawka
2012-03-02 13:53 ` John Crispin
2012-03-01 16:52 ` [PATCH 6/7] neterion/s2io: fix s2io_set_mac_addr() to prevent double checks Danny Kukawka
2012-03-01 16:52 ` [PATCH 7/7] octeon: use dev_set_mac_address() instead of octeon_mgmt_set_mac_address() Danny Kukawka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301.162130.2267876784560089802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=danny.kukawka@bisect.de \
--cc=dkukawka@suse.de \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).