From: David Miller <davem@davemloft.net>
To: b.van.den.berg.nl@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, srk@ti.com,
vinay.hegde@ti.com, cyril@ti.com, richard.cochran@omicron.at,
Julia.Lawall@lip6.fr, s.hauer@pengutronix.de, joe@perches.com
Subject: Re: [PATCH] davinci_emac: fixed setting MAC at init time
Date: Thu, 01 Mar 2012 16:28:37 -0500 (EST) [thread overview]
Message-ID: <20120301.162837.1843924175078247309.davem@davemloft.net> (raw)
In-Reply-To: <20120301084239.GA17146@altenpts-laptop>
From: Bas van den Berg <b.van.den.berg.nl@gmail.com>
Date: Thu, 1 Mar 2012 09:42:42 +0100
> Without this patch, the MAC number will show up as zero's until the interface
> is brought up for the first time. (eg. with ifconfig -a)
>
> Signed-off-by: Bas van den Berg <b.van.den.berg.nl@gmail.com>
Well then the copy (which is also unnecessarily by hand using a loop
instead of a memcpy call) in emac_dev_open() is redundant and should
be removed when you make this change.
prev parent reply other threads:[~2012-03-01 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 8:42 [PATCH] davinci_emac: fixed setting MAC at init time Bas van den Berg
2012-03-01 21:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301.162837.1843924175078247309.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Julia.Lawall@lip6.fr \
--cc=b.van.den.berg.nl@gmail.com \
--cc=cyril@ti.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richard.cochran@omicron.at \
--cc=s.hauer@pengutronix.de \
--cc=srk@ti.com \
--cc=vinay.hegde@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).