* [PATCH] davinci_emac: fixed setting MAC at init time
@ 2012-03-01 8:42 Bas van den Berg
2012-03-01 21:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Bas van den Berg @ 2012-03-01 8:42 UTC (permalink / raw)
To: davem, netdev, linux-kernel
Cc: Sriram, Vinay Hegde, Cyril Chemparathy, Richard Cochran,
Julia Lawall, Sascha Hauer, Joe Perches
Without this patch, the MAC number will show up as zero's until the interface
is brought up for the first time. (eg. with ifconfig -a)
Signed-off-by: Bas van den Berg <b.van.den.berg.nl@gmail.com>
---
drivers/net/ethernet/ti/davinci_emac.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 4b2f545..11b169a 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1904,6 +1904,7 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "using random MAC addr: %pM\n",
priv->mac_addr);
}
+ memcpy(ndev->dev_addr, priv->mac_addr, ndev->addr_len);
ndev->netdev_ops = &emac_netdev_ops;
SET_ETHTOOL_OPS(ndev, ðtool_ops);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] davinci_emac: fixed setting MAC at init time
2012-03-01 8:42 [PATCH] davinci_emac: fixed setting MAC at init time Bas van den Berg
@ 2012-03-01 21:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-03-01 21:28 UTC (permalink / raw)
To: b.van.den.berg.nl
Cc: netdev, linux-kernel, srk, vinay.hegde, cyril, richard.cochran,
Julia.Lawall, s.hauer, joe
From: Bas van den Berg <b.van.den.berg.nl@gmail.com>
Date: Thu, 1 Mar 2012 09:42:42 +0100
> Without this patch, the MAC number will show up as zero's until the interface
> is brought up for the first time. (eg. with ifconfig -a)
>
> Signed-off-by: Bas van den Berg <b.van.den.berg.nl@gmail.com>
Well then the copy (which is also unnecessarily by hand using a loop
instead of a memcpy call) in emac_dev_open() is redundant and should
be removed when you make this change.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-01 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01 8:42 [PATCH] davinci_emac: fixed setting MAC at init time Bas van den Berg
2012-03-01 21:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).