From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: masa-korg@dsn.okisemi.com, paul.gortmaker@windriver.com,
jeffrey.t.kirsher@intel.com, mirq-linux@rere.qmqm.pl,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pch_gbe: memory corruption calling pch_gbe_validate_option()
Date: Thu, 01 Mar 2012 17:24:02 -0500 (EST) [thread overview]
Message-ID: <20120301.172402.1035366198258013912.davem@davemloft.net> (raw)
In-Reply-To: <20120301071708.GB6959@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 1 Mar 2012 10:17:08 +0300
> pch_gbe_validate_option() modifies 32 bits of memory but we pass
> &hw->phy.autoneg_advertised which only has 16 bits and &hw->mac.fc
> which only has 8 bits.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
next prev parent reply other threads:[~2012-03-01 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 7:17 [patch] pch_gbe: memory corruption calling pch_gbe_validate_option() Dan Carpenter
2012-03-01 22:24 ` David Miller [this message]
2012-03-05 5:34 ` santosh prasad nayak
2012-03-05 6:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301.172402.1035366198258013912.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).