From: David Miller <davem@davemloft.net>
To: gustavo@padovan.org
Cc: johan.hedberg@gmail.com, linville@tuxdriver.com, netdev@vger.kernel.org
Subject: Re: pull request: bluetooth-next 2012-03-01
Date: Thu, 01 Mar 2012 22:23:16 -0500 (EST) [thread overview]
Message-ID: <20120301.222316.1877216960521396397.davem@davemloft.net> (raw)
In-Reply-To: <20120301.221643.881299898523907213.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 01 Mar 2012 22:16:43 -0500 (EST)
> This was only three commits into your tree, therefore I'm not very
> optimistic to be honest with you.
In the very next commit, 3175405b906a85ed2bad21e09c444266e4a05a8e we end
up with:
mgmt_device_found(hdev, &info->bdaddr, ACL_LINK, 0x00,
info->dev_class, 0, 1, NULL);
which after all the rest of the commits still looks like:
mgmt_device_found(hdev, &info->bdaddr, ACL_LINK, 0x00,
info->dev_class, 0, !name_known, ssp,
NULL, 0);
You have to make those arguments line up properly:
mgmt_device_found(hdev, &info->bdaddr, ACL_LINK, 0x00,
info->dev_class, 0, !name_known, ssp,
NULL, 0);
next prev parent reply other threads:[~2012-03-02 3:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 2:55 pull request: bluetooth-next 2012-03-01 Gustavo Padovan
2012-03-02 3:16 ` David Miller
2012-03-02 3:23 ` David Miller [this message]
2012-03-02 3:26 ` David Miller
2012-03-02 4:13 ` Joe Perches
2012-03-02 5:35 ` [PATCH] checkpatch: Add --strict tests for braces, comments and casts Joe Perches
2012-03-02 5:54 ` [PATCH] checkpatch: Add --strict test for strings split across multiple lines Joe Perches
2012-03-02 16:37 ` pull request: bluetooth-next 2012-03-01 Gustavo Padovan
2012-03-02 21:15 ` David Miller
2012-03-03 16:46 ` Gustavo Padovan
2012-03-03 19:46 ` David Miller
2012-03-03 19:47 ` David Miller
2012-03-03 20:04 ` Joe Perches
2012-03-03 20:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301.222316.1877216960521396397.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).