From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Marcel Holtmann <marcel@holtmann.org>,
santosh nayak <santoshprasadnayak@gmail.com>,
padovan@profusion.mobi, davem@davemloft.net,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Ville Tervo <ville.tervo@nokia.com>
Subject: Re: [PATCH] Bluetooth: Silence static checker warning.
Date: Fri, 2 Mar 2012 14:04:20 +0300 [thread overview]
Message-ID: <20120302110420.GH22598@mwanda> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6E88@saturn3.aculab.com>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Fri, Mar 02, 2012 at 09:15:37AM -0000, David Laight wrote:
> How long has this code been in tree?
> It isn't obvious to me that this change won't break code on BE systems
> where the application code is already fixing the endianness.
>
It looks like we've had an endian bug since last February.
b62f328b8f20a "Bluetooth: Add server socket support for LE
connection"
+ l2cap_pi(sk)->scid = la.l2_cid;
->scid was cpu endian.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-02 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 17:06 [PATCH] Bluetooth: Silence static checker warning santosh nayak
[not found] ` <1330535217-26785-1-git-send-email-santoshprasadnayak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-29 17:39 ` Marcel Holtmann
2012-02-29 17:46 ` Marcel Holtmann
2012-03-02 9:15 ` David Laight
2012-03-02 11:04 ` Dan Carpenter [this message]
2012-03-02 17:57 ` Marcel Holtmann
2012-02-29 19:16 ` Dan Carpenter
2012-02-29 20:45 ` Andrei Emeltchenko
[not found] ` <CAMXE1-oXtheVHDuU3w52mXqmuY8AK4kk+tuvJpVRDq2=+qEnsQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-01 5:37 ` santosh prasad nayak
2012-03-01 6:25 ` Dan Carpenter
2012-03-01 7:43 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302110420.GH22598@mwanda \
--to=dan.carpenter@oracle.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
--cc=santoshprasadnayak@gmail.com \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).