From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: santosh nayak <santoshprasadnayak@gmail.com>,
coreteam@netfilter.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter@vger.kernel.org, bart.de.schuymer@pandora.be,
netfilter-devel@vger.kernel.org, shemminger@vyatta.com,
davem@davemloft.net
Subject: Re: [PATCH 2/3] netfilter: potential null derefence.
Date: Sat, 3 Mar 2012 10:11:53 +0100 [thread overview]
Message-ID: <20120303091153.GA17253@1984> (raw)
In-Reply-To: <4F513C2B.6030604@pandora.be>
On Fri, Mar 02, 2012 at 10:31:23PM +0100, Bart De Schuymer wrote:
> Op 1/03/2012 13:30, Pablo Neira Ayuso schreef:
> >On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:
> >>From: Santosh Nayak<santoshprasadnayak@gmail.com>
> >>
> >>I am getting following error.
> >>" net/bridge/netfilter/ebtables.c:269 ebt_do_table()
> >> error: potential null derefence 'cs'"
> >>
> >> i = cs[sp].n; // If cs == Null then this will cause problem.
> >
> >Very sorry, I didn't see the out label.
> >
> >I'll apply this to my nf [1] once David takes my previous request for
> >pulling.
> >
>
> Hi,
>
> Has this patch been tested? Really, that code in the core firewall
> function is there for a reason, wouldn't you think?
> The chainstack is only allocated when user-defined chains are used
> (see translate_table).
> Never blindly trust a tool.
I see, then that cs NULL dereference never happens.
Thanks Bart, I'll drop this patch.
next prev parent reply other threads:[~2012-03-03 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:17 [PATCH 2/3] netfilter: potential null derefence santosh nayak
2012-03-01 10:21 ` Pablo Neira Ayuso
2012-03-01 10:23 ` santosh prasad nayak
2012-03-01 12:30 ` Pablo Neira Ayuso
2012-03-02 21:31 ` Bart De Schuymer
2012-03-03 9:11 ` Pablo Neira Ayuso [this message]
2012-03-02 1:22 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120303091153.GA17253@1984 \
--to=pablo@netfilter.org \
--cc=bart.de.schuymer@pandora.be \
--cc=bdschuym@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).