From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH] vlan: Support sending custom Ethernet CRC.
Date: Mon, 05 Mar 2012 23:12:13 -0500 (EST) [thread overview]
Message-ID: <20120305.231213.1657967586545663587.davem@davemloft.net> (raw)
In-Reply-To: <4F558BBD.1050400@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Mon, 05 Mar 2012 19:59:57 -0800
> On 03/05/2012 06:14 PM, David Miller wrote:
>> From: greearb@candelatech.com
>> Date: Mon, 5 Mar 2012 18:05:58 -0800
>>
>>> NOTE: You will probably have to disable any
>>> VLAN hardware assist on the underlying device to get
>>> this to properly send packets with this feature enabled.
>>
>> This need to be therefore handled specifically on a device-by-device
>> basis, and VLAN custom CRC disabled unless the device explicitly
>> states that it can handle this situation properly and has any
>> necessary feature rule enforcement codified.
>
> I'll see what I can come up with. Maybe figure out how to propagate
> a flag up from the NIC when it is in a state that can handle VLAN +
> custom-CRC
> and only enable the flag on the VLAN in that case...
NETIF_F_CAN_VLAN_WITH_CUSTOM_CRC
next prev parent reply other threads:[~2012-03-06 4:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 2:05 [PATCH] vlan: Support sending custom Ethernet CRC greearb
2012-03-06 2:14 ` David Miller
2012-03-06 3:59 ` Ben Greear
2012-03-06 4:12 ` David Miller [this message]
2012-03-06 16:16 ` Ben Hutchings
2012-03-06 19:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305.231213.1657967586545663587.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).