From: David Miller <davem@davemloft.net>
To: paulius.zaleckas@gmail.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: fix "entering disabled state" logging
Date: Tue, 06 Mar 2012 14:33:55 -0500 (EST) [thread overview]
Message-ID: <20120306.143355.1005128775927562130.davem@davemloft.net> (raw)
In-Reply-To: <4F56208E.2090801@gmail.com>
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Date: Tue, 06 Mar 2012 16:34:54 +0200
> On 03/06/2012 04:22 PM, Paulius Zaleckas wrote:
>> Now we have:
>> eth0: link down
>> br0: port 1(eth0) entering forwarding state
>>
>> State should be logged *after* it was changed, not before.
>
> The funny thing is that it was introduced:
> 2010-05-16 stephen hemminger
> bridge: change console message interface
> 28a16c97963d3bc36a2c192859f6d8025ef2967a
>
> and no one noticed since then :D
No, someone noticed, you're not the first person to propose this
patch and it was rejected just like your's will be.
next prev parent reply other threads:[~2012-03-06 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 14:22 [PATCH] bridge: fix "entering disabled state" logging Paulius Zaleckas
2012-03-06 14:34 ` Paulius Zaleckas
2012-03-06 17:09 ` Stephen Hemminger
2012-03-06 19:33 ` David Miller [this message]
2012-03-06 19:33 ` David Miller
2012-03-07 8:04 ` Paulius Zaleckas
2012-03-08 3:59 ` David Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306.143355.1005128775927562130.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).