From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, hayeswang@realtek.com,
snanda@chromium.org, rjw@sisk.pl, stern@rowland.harvard.edu
Subject: Re: [PATCH] r8169: runtime resume before shutdown.
Date: Tue, 06 Mar 2012 15:15:03 -0500 (EST) [thread overview]
Message-ID: <20120306.151503.848145173320023273.davem@davemloft.net> (raw)
In-Reply-To: <20120306111412.GA1805@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Tue, 6 Mar 2012 12:14:12 +0100
> With runtime PM, if the ethernet cable is disconnected, the device is
> transitioned to D3 state to conserve energy. If the system is shutdown
> in this state, any register accesses in rtl_shutdown are dropped on
> the floor. As the device was programmed by .runtime_suspend() to wake
> on link changes, it is thus brought back up as soon as the link recovers.
>
> Resuming every suspended device through the driver core would slow things
> down and it is not clear how many devices really need it now.
>
> Original report and D0 transition patch by Sameer Nanda. Patch has been
> changed to comply with advices by Rafael J. Wysocki and the PM folks.
>
> Reported-by: Sameer Nanda <snanda@chromium.org>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Hayes Wang <hayeswang@realtek.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> ---
>
> This sucker turned my silent wake-on-alarm workstation into an early
> sunday morning testbed takeoff. Please consider before 3.3 goes out.
Applied.
prev parent reply other threads:[~2012-03-06 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 11:14 [PATCH] r8169: runtime resume before shutdown Francois Romieu
2012-03-06 19:18 ` Rafael J. Wysocki
2012-03-06 20:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306.151503.848145173320023273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=romieu@fr.zoreil.com \
--cc=snanda@chromium.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).