netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, srinivas.kandagatla@st.com
Subject: Re: [PATCH] stmmac: Allow stmmac to work with other PHY buses(v2).
Date: Tue, 06 Mar 2012 16:57:03 -0500 (EST)	[thread overview]
Message-ID: <20120306.165703.277843706808689044.davem@davemloft.net> (raw)
In-Reply-To: <1331012520-19574-1-git-send-email-peppe.cavallaro@st.com>

From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Tue,  6 Mar 2012 06:42:00 +0100

> After commit "db8857b stmmac: use an unique MDIO bus name" and "90b9a54
> stmmac: fix phy naming inconsistency" stmmac cant work with other MDIO
> buses, because mdio_bus name is fixed in the dirver.

This sounds inaccurate, you're making it sound like these commits
introduced this limitation, as far as I can tell they did not.

Before the MDIO bus name was just plain "%x" and the bus_id number
was placed there.  Then it became the same thing, except with some
(potentially fixed) prefix.

Nothing about that change makes any difference whatsoever about
what you're modifications are trying to allow.

BTW, also, commit "90b9a54" is ambiguous.

[davem@bql net]$ git show 90b9a54
error: short SHA1 90b9a54 is ambiguous.
error: short SHA1 90b9a54 is ambiguous.
fatal: ambiguous argument '90b9a54': unknown revision or path not in the working tree.

  reply	other threads:[~2012-03-06 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06  5:42 [PATCH] stmmac: Allow stmmac to work with other PHY buses(v2) Giuseppe CAVALLARO
2012-03-06 21:57 ` David Miller [this message]
2012-03-07  8:08   ` Srinivas KANDAGATLA
2012-03-08  9:16     ` Florian Fainelli
2012-03-08 14:03     ` Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120306.165703.277843706808689044.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=srinivas.kandagatla@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).