From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: cascardo@linux.vnet.ibm.com, netdev@vger.kernel.org, anton@samba.org
Subject: Re: [PATCH] ehea: restore multicast and rx_errors fields
Date: Thu, 08 Mar 2012 00:23:29 -0800 (PST) [thread overview]
Message-ID: <20120308.002329.1825008264770615652.davem@davemloft.net> (raw)
In-Reply-To: <1331131491.2474.71.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 07 Mar 2012 06:44:51 -0800
> Le mercredi 07 mars 2012 à 11:17 -0300, Thadeu Lima de Souza Cascardo a
> écrit :
>
>> Tested, in particular, the multicast stat, pinging 224.0.0.1 from
>> another machine.
>>
>> Thanks.
>> Cascardo.
>>
>> Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
>> Tested-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
>>
>
> Thanks !
>
> Maybe you could submit a followup patch, to remove the port->stats
> structure and only use two u64 fields, since this driver only use two
> counters in its private "stats" ?
Yes that sounds like a good idea.
I've applied Eric's patch to 'net'.
prev parent reply other threads:[~2012-03-08 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 5:46 [PATCH] ehea: restore multicast and rx_errors fields Eric Dumazet
2012-03-07 14:17 ` Thadeu Lima de Souza Cascardo
2012-03-07 14:44 ` Eric Dumazet
2012-03-08 8:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308.002329.1825008264770615652.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=cascardo@linux.vnet.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox