From: David Miller <davem@davemloft.net>
To: nick.jones@network-box.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: perform inetpeer binding at dst creation, with readonly option
Date: Thu, 08 Mar 2012 13:40:57 -0800 (PST) [thread overview]
Message-ID: <20120308.134057.343430189436877920.davem@davemloft.net> (raw)
In-Reply-To: <4F58D9F5.1080902@network-box.com>
From: Nick Jones <nick.jones@network-box.com>
Date: Fri, 09 Mar 2012 00:10:29 +0800
> However, seeing a kmalloc done for such a transient, sparse
> structure didn't sit so well in the stomach. If we can be sure that
> the metrics of a dst for an icmp6 packet won't be written to, we
> could use the static const ip6_template_metrics array defined in
> route.c:~205, it has RTAX_HOPLIMIT fixed at 255, and using it avoids
> a kmalloc.
>
> I'll produce another patch for this strategy if you think this is a
> better idea.
This could work, but you'll need to add an assertion or similar to make
sure this requirement always holds.
prev parent reply other threads:[~2012-03-08 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 15:49 [PATCH net-next] ipv6: perform inetpeer binding at dst creation, with readonly option Nick Jones
2012-03-06 21:05 ` David Miller
2012-03-08 16:10 ` Nick Jones
2012-03-08 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308.134057.343430189436877920.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nick.jones@network-box.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).