From: Gustavo Padovan <padovan@profusion.mobi>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: marcel@holtmann.org, davem@davemloft.net,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: Resend: [PATCH] Bluetooth: Fix Endian Bug.
Date: Thu, 8 Mar 2012 02:33:21 -0300 [thread overview]
Message-ID: <20120308053320.GD3998@joana> (raw)
In-Reply-To: <1330622196-12967-1-git-send-email-santoshprasadnayak@gmail.com>
Hi Santosh,
* santosh nayak <santoshprasadnayak@gmail.com> [2012-03-01 22:46:36 +0530]:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Fix network to host endian conversion for L2CAP chan id.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bluetooth/l2cap_sock.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> index 401d942..86d5067 100644
> --- a/net/bluetooth/l2cap_sock.c
> +++ b/net/bluetooth/l2cap_sock.c
> @@ -82,7 +82,7 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)
> }
>
> if (la.l2_cid)
> - err = l2cap_add_scid(chan, la.l2_cid);
> + err = l2cap_add_scid(chan, __le16_to_cpu(la.l2_cid));
This is kind weird, la.l2_cid comes from the user, so it is already in host
endian. No need for convertions here.
Gustavo
next prev parent reply other threads:[~2012-03-08 5:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 17:16 Resend: [PATCH] Bluetooth: Fix Endian Bug santosh nayak
2012-03-02 7:44 ` Dan Carpenter
2012-03-08 5:33 ` Gustavo Padovan [this message]
2012-03-08 17:53 ` Marcel Holtmann
2012-03-09 12:21 ` Andrei Emeltchenko
2012-03-09 12:45 ` Gustavo Padovan
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 10:59 santosh nayak
2012-03-01 12:35 ` Andrei Emeltchenko
2012-03-01 14:04 ` santosh prasad nayak
2012-03-02 12:32 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308053320.GD3998@joana \
--to=padovan@profusion.mobi \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).