From: John Fastabend <john.r.fastabend@intel.com>
To: jhs@mojatatu.com, shemminger@vyatta.com, bhutchings@solarflare.com
Cc: hadi@cyberus.ca, roprabhu@cisco.com, netdev@vger.kernel.org,
mst@redhat.com, chrisw@redhat.com, davem@davemloft.net,
gregory.v.rose@intel.com, kvm@vger.kernel.org, sri@us.ibm.com,
chealy@imsco-us.com
Subject: [RFC PATCH v1 0/4] net: bridge: FDB management
Date: Fri, 09 Mar 2012 14:47:50 -0800 [thread overview]
Message-ID: <20120309223621.2514.82321.stgit@jf-dev1-dcblab> (raw)
This series is a follow up to the previous thread here:
http://lists.openwall.net/netdev/2012/02/29/31
There are some significant changes in this series. First
I add two NTF_XXX bits to signal if the PF_BRIDGE netlink
command should be parsed by the embedded bridge or the
SW bridge. The insight here is the SW bridge is always the
master device (NTF_MASTER) and the embedded bridge is
the lower device (NTF_LOWERDEV). Without either flag set
the command is parsed by the SW bridge to support existing
tooling.
To make this work correctly I added three new ndo ops
ndo_fdb_add
ndo_fdb_del
ndo_fdb_dump
to add, delete, and dump FDB entries. These operations
can be used by drivers to program embedded nics or by
software bridges. We have at least three SW bridge now
net/bridge, openvswitch, and macvlan. And three variants
of embedded bridges SR-IOV devices, multi-function devices
and Distributed Switch Architecture (DSA).
I think at least in this case adding netdevice ops is
the cleanest way to implement this. I thought about
notifier hooks and other methods but for now at least
this seems to be the simplest.
I'm going to drop this into my testbed and let it run
for a few days. But I think (hope?) this series is close
to being ready for a non-RFC submission. I'll probably
audit the patches once more as well.
Thanks to Stephen, Ben, and Jamal for bearing with me
and the feedback on the last round of patches.
As always any comments/feedback is appreciated!
---
John Fastabend (4):
ixgbe: enable FDB netdevice ops
net: add fdb generic dump routine
net: addr_list: add exclusive dev_uc_add
net: add generic PF_BRIDGE:RTM_XXX FDB hooks
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 59 ++++++++
include/linux/neighbour.h | 3
include/linux/netdevice.h | 27 +++
include/linux/rtnetlink.h | 4 +
net/bridge/br_device.c | 3
net/bridge/br_fdb.c | 128 ++++------------
net/bridge/br_netlink.c | 12 --
net/bridge/br_private.h | 15 ++
net/core/dev_addr_lists.c | 19 ++
net/core/rtnetlink.c | 194 +++++++++++++++++++++++++
10 files changed, 352 insertions(+), 112 deletions(-)
--
Signature
next reply other threads:[~2012-03-09 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 22:47 John Fastabend [this message]
2012-03-09 22:48 ` [RFC PATCH v1 2/4] net: addr_list: add exclusive dev_uc_add John Fastabend
2012-03-09 22:48 ` [RFC PATCH v1 3/4] net: add fdb generic dump routine John Fastabend
2012-03-09 22:48 ` [RFC PATCH v1 4/4] ixgbe: enable FDB netdevice ops John Fastabend
2012-03-10 3:48 ` Stephen Hemminger
2012-03-10 5:06 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309223621.2514.82321.stgit@jf-dev1-dcblab \
--to=john.r.fastabend@intel.com \
--cc=bhutchings@solarflare.com \
--cc=chealy@imsco-us.com \
--cc=chrisw@redhat.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=hadi@cyberus.ca \
--cc=jhs@mojatatu.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
--cc=shemminger@vyatta.com \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).