Re: [net 2/2] net: fix a bug of dropping FCoE frames when disabling tx ip checksum

[Stephen Hemminger <shemminger@vyatta.com>]

On Wed, 14 Mar 2012 00:01:58 -0700
Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:

> From: Yi Zou <yi.zou@intel.com>
> 
> Fix a bug when using 'ethtool -K ethx tx off' to turn off tx ip checksum,
> FCoE CRC offload should not be impacte. The skb_checksum_help() is needed
> only if it's not FCoE traffic for ip checksum, regardless of ethtool toggling
> the tx ip checksum on or off.
> 
> Signed-off-by: Yi Zou <yi.zou@intel.com>
> Tested-by: Ross Brattain <ross.b.brattain@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>  net/core/dev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 6ca32f6..9e378009 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1913,6 +1913,9 @@ int skb_checksum_help(struct sk_buff *skb)
>  	__wsum csum;
>  	int ret = 0, offset;
>  
> +	if (skb->protocol == htons(ETH_P_FCOE))
> +		goto out;
> +
>  	if (skb->ip_summed == CHECKSUM_COMPLETE)
>  		goto out_set_summed;
>  

Shouldn't this be done in the offending driver rather than the core?