From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 00/34] Pull request for 'davem-next.base_addr.removal' branch
Date: Thu, 15 Mar 2012 15:05:26 -0700 (PDT) [thread overview]
Message-ID: <20120315.150526.353003174998399838.davem@davemloft.net> (raw)
In-Reply-To: <cover.1331814082.git.romieu@fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 15 Mar 2012 14:56:57 +0100
> Please pull from branch 'davem-next.base_addr.removal' in repository
>
> git://violet.fr.zoreil.com/romieu/linux davem-next.base_addr.removal
>
> to get the changes below.
I don't think you can blindly override outl, readl, etc. with defines
without first properly undefining them. Otherwise via indirect header
inclusion the asm/io.h definition will be present already and this
will result in compiler failures.
Frankly, I think you should just do it right, by overriding some
private macro for this purpose in such drivers and then do the
necessary sed 's/outl/foow32/' or whatever over the whole driver.
Please also address the other feedback you've received so far.
Thanks.
prev parent reply other threads:[~2012-03-15 22:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 13:56 [PATCH net-next 00/34] Pull request for 'davem-next.base_addr.removal' branch Francois Romieu
2012-03-15 13:56 ` [PATCH net-next 01/34] sungem: stop using net_device.{base_addr, irq} Francois Romieu
2012-03-15 13:56 ` [PATCH net-next 02/34] tehuti: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 03/34] forcedeth: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 04/34] atl1c: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 05/34] via-rhine: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 06/34] hamachi: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 07/34] via-velocity: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 08/34] sundance: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 09/34] vxge: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 10/34] fealnx: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 11/34] atl1e: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 12/34] s2io: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 13/34] 8139cp: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 14/34] yellowfin: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 15/34] starfire: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 16/34] starfire: remove deprecated options Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 17/34] bnx2: stop using net_device.{base_addr, irq} Francois Romieu
2012-03-15 20:47 ` Michael Chan
2012-03-15 13:57 ` [PATCH net-next 18/34] winbond840: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 19/34] sc92031: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 20/34] sis190: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 21/34] tulip_core: " Francois Romieu
2012-04-04 14:52 ` Grant Grundler
2012-03-15 13:57 ` [PATCH net-next 22/34] sunhme: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 23/34] uli526x: fix regions leak in driver probe error path Francois Romieu
2012-04-04 19:10 ` Grant Grundler
2012-03-15 13:57 ` [PATCH net-next 24/34] xircom_cb: fix device " Francois Romieu
2012-04-04 1:10 ` Grant Grundler
2012-03-15 13:57 ` [PATCH net-next 25/34] xircom_cb: stop using net_device.{base_addr, irq} and convert to __iomem Francois Romieu
2012-04-04 1:23 ` Grant Grundler
2012-03-15 13:57 ` [PATCH net-next 26/34] de2104x: stop using net_device.{base_addr, irq} Francois Romieu
2012-04-04 1:15 ` Grant Grundler
2012-03-15 13:57 ` [PATCH net-next 27/34] smsc9420: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 28/34] natsemi: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 29/34] 8139too: dev->{base_addr, irq} removal Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 30/34] dl2k: stop using net_device.{base_addr, irq} and convert to __iomem Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 31/34] uli526x: " Francois Romieu
2012-03-18 6:33 ` Grant Grundler
2012-03-15 13:57 ` [PATCH net-next 32/34] epic100: " Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 33/34] dmfe: " Francois Romieu
2012-03-16 17:48 ` Grant Grundler
2012-03-17 11:31 ` Francois Romieu
2012-03-15 13:57 ` [PATCH net-next 34/34] sis900: " Francois Romieu
2012-03-15 22:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315.150526.353003174998399838.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).