From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: eric.dumazet@gmail.com, greearb@candelatech.com,
netdev@vger.kernel.org, kys@microsoft.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] net/hyperv: fix erroneous NETDEV_TX_BUSY use
Date: Fri, 16 Mar 2012 02:02:27 -0700 (PDT) [thread overview]
Message-ID: <20120316.020227.1430670417323299238.davem@davemloft.net> (raw)
In-Reply-To: <A1F3067C9B68744AA19F6802BAB8FFDC0DCE70A5@TK5EX14MBXC223.redmond.corp.microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Wed, 14 Mar 2012 20:29:13 +0000
>
>
>> -----Original Message-----
>> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
>> Sent: Wednesday, March 14, 2012 4:15 PM
>> To: Haiyang Zhang
>> Cc: Ben Greear; David Miller; netdev; KY Srinivasan; Greg Kroah-Hartman
>> Subject: RE: [PATCH] net/hyperv: fix erroneous NETDEV_TX_BUSY use
>>
>> On Wed, 2012-03-14 at 20:00 +0000, Haiyang Zhang wrote:
>>
>> > Actually, I'm working on this bug, and have a patch under our internal
>> > review now. My fix is actually not freeing the SKB, and return
>> NETDEV_TX_BUSY.
>> >
>> > Even if the vmbus ring buffer is busy currently, it can be available
>> during
>> > the next re-try, because the host is taking away data from ring buffer.
>> The
>> > stop/wake queue mechanism is in the netvsc.c file.
>> >
>> > In the out-of-memory case, dropping packet and return NETDEV_TX_OK seems
>> fine.
>>
>> That will be fine for net-next.
>>
>> I sent a patch for current kernels, where obvious and minimal fixes
>> apply.
>
> Sounds good. Thanks.
>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
>
APplied.
prev parent reply other threads:[~2012-03-16 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 18:53 [PATCH] net/hyperv: fix erroneous NETDEV_TX_BUSY use Eric Dumazet
2012-03-14 18:56 ` Ben Greear
2012-03-14 19:17 ` Eric Dumazet
2012-03-14 20:00 ` Haiyang Zhang
2012-03-14 20:14 ` Eric Dumazet
2012-03-14 20:29 ` Haiyang Zhang
2012-03-16 9:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316.020227.1430670417323299238.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox