From: David Miller <davem@davemloft.net>
To: alexey.orishko@gmail.com
Cc: netdev@vger.kernel.org, oliver@neukum.org,
linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
alexey.orishko@stericsson.com
Subject: Re: [PATCH net-next 4/4] cdc_ncm: remove redundant header files
Date: Fri, 16 Mar 2012 02:08:06 -0700 (PDT) [thread overview]
Message-ID: <20120316.020806.2142585782724456200.davem@davemloft.net> (raw)
In-Reply-To: <1331760373-1914-4-git-send-email-alexey.orishko@stericsson.com>
From: Alexey Orishko <alexey.orishko@gmail.com>
Date: Wed, 14 Mar 2012 22:26:13 +0100
> Signed-off-by: Alexey Orishko <alexey.orishko@stericsson.com>
I'm not applying this.
> -#include <linux/ethtool.h>
This file does very much do use the types in ethtool.h
I have a feeling you weren't very meticulious about this change
and basically said "it compiles, must be good".
next prev parent reply other threads:[~2012-03-16 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 21:26 [PATCH net-next 1/4] cdc_ncm: reduce driver latency in the data path Alexey Orishko
[not found] ` <1331760373-1914-1-git-send-email-alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2012-03-14 21:26 ` [PATCH net-next 2/4] cdc_ncm: fix MTU and max_datagram_size handling Alexey Orishko
2012-03-16 9:08 ` David Miller
2012-03-14 21:26 ` [PATCH net-next 4/4] cdc_ncm: remove redundant header files Alexey Orishko
2012-03-16 9:08 ` David Miller [this message]
2012-03-14 21:26 ` [PATCH net-next 3/4] cdc_ncm: avoid discarding datagrams in rx path Alexey Orishko
2012-03-16 9:08 ` David Miller
2012-03-16 9:08 ` [PATCH net-next 1/4] cdc_ncm: reduce driver latency in the data path David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316.020806.2142585782724456200.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.orishko@gmail.com \
--cc=alexey.orishko@stericsson.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).