netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gaofeng@cn.fujitsu.com
Cc: steffen.klassert@secunet.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment
Date: Fri, 16 Mar 2012 21:58:13 -0700 (PDT)	[thread overview]
Message-ID: <20120316.215813.1949007994742764009.davem@davemloft.net> (raw)
In-Reply-To: <1331888235-10368-1-git-send-email-gaofeng@cn.fujitsu.com>

From: Gao feng <gaofeng@cn.fujitsu.com>
Date: Fri, 16 Mar 2012 16:57:15 +0800

> Since commit 299b0767(ipv6: Fix IPsec slowpath fragmentation problem)
> In func ip6_append_data,after call skb_put(skb, fraglen + dst_exthdrlen)
> the skb->len contains dst_exthdrlen,and we don't reduce dst_exthdrlen at last
> This will make fraggap>0 in next "while cycle",and cause the size of skb incorrent
> 
> Call skb_pull reduce skb->len before next "while cycle"
> 
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>

Steffen please review this patch.

> ---
>  net/ipv6/ip6_output.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index d97e071..f67f840 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -1450,7 +1450,8 @@ alloc_new_skb:
>  				kfree_skb(skb);
>  				goto error;
>  			}
> -
> +
> +			skb_pull(skb, dst_exthdrlen);
>  			offset += copy;
>  			length -= datalen - fraggap;
>  			transhdrlen = 0;
> -- 
> 1.7.5.4

  reply	other threads:[~2012-03-17  4:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16  8:57 [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment Gao feng
2012-03-17  4:58 ` David Miller [this message]
2012-03-19  8:02 ` Steffen Klassert
2012-03-19 21:21   ` David Miller
2012-03-20  1:09   ` Gao feng
2012-03-20  3:22   ` [PATCH v2] " Gao feng
2012-03-20  7:58     ` Steffen Klassert
2012-03-20  8:36       ` [PATCH v3] " Gao feng
2012-03-20  8:54         ` Steffen Klassert
2012-03-20  9:40           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120316.215813.1949007994742764009.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=gaofeng@cn.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).