From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] arp: allow arp processing to honor per interface arp_accept sysctl
Date: Fri, 16 Mar 2012 23:00:40 -0700 (PDT) [thread overview]
Message-ID: <20120316.230040.750082168470218493.davem@davemloft.net> (raw)
In-Reply-To: <1331825158-17584-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 15 Mar 2012 11:25:58 -0400
> I found recently that the arp_process function which handles all of our received
> arp frames, is using IPV4_DEVCONF_ALL macro to check the state of the arp_process
> flag. This seems wrong, as it implies that either none or all of the network
> interfaces accept gratuitous arps. This patch corrects that, allowing
> per-interface arp_accept configuration to deviate from the all setting. Note
> this also brings us into line with the way the arp_filter setting is handled
> during arp_process execution.
>
> Tested this myself on my home network, and confirmed it works as expected.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied to net-next, thanks Neil.
prev parent reply other threads:[~2012-03-17 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 15:25 [PATCH] arp: allow arp processing to honor per interface arp_accept sysctl Neil Horman
2012-03-17 6:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316.230040.750082168470218493.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).