From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails. Date: Fri, 16 Mar 2012 23:18:56 -0700 (PDT) Message-ID: <20120316.231856.1071253468993560433.davem@davemloft.net> References: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hjlipp@web.de, tilman@imap.cc, isdn@linux-pingi.de, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org To: santoshprasadnayak@gmail.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:39961 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754226Ab2CQGTQ (ORCPT ); Sat, 17 Mar 2012 02:19:16 -0400 In-Reply-To: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: santosh nayak Date: Fri, 16 Mar 2012 18:40:13 +0530 > We have 3 callers: gigaset_probe(), gigaset_tty_open() and > gigaset_probe(). Each caller tries to free allocated memory > if lock fails. This is possible if we returns -EINTR. Look again at the callers. They interpret "0" as an error, so your patch would break the driver.