Re: Sundance network driver (D-Link DFE-580TX) timeouts rendering interface unusable

[Jonathan Nieder <jrnieder@gmail.com>]

Hi again,

Mike . wrote:

>> Oh well, we also must make sure we held np->lock in TX completion when
>> doing our test to eventually call netif_wake_queue(), I missed it was
>> released too early.
>>
>> here is a more complete patch.
>
> I applied the patch, recompiled the module, loaded it into the kernel and
> started testing traffic on the interface with the following result :
>
> [ 1124.008030] ------------[ cut here ]------------
> [ 1124.008101] WARNING: at /build/buildd-linux-2.6_3.2.1-2-i386-4wAPNj/linux-2.6-3.2.1/debian/build/source_i386_none/net/sched/sch_generic.c:255 dev_watchdog+0xb1/0x104()
> [ 1124.008201] Hardware name:
> [ 1124.008252] NETDEV WATCHDOG: eth1 (sundance): transmit queue 0 timed out
[...]
> After this the same repeat of transmit timeouts (as posted earlier) in the
> log untill I down the interface.

Thanks.  I assume current 3.3 release candidates behave the same way.

Based on [2], it looks like v2.6.25-rc9~99^2~24 ([NET]: Add preemption
point in qdisc_run, 2008-03-28) made this easier to trip.

As for the next step: I'd suggest posting a summary of the symptoms,
which kernel versions you have tested, and a link to [1] at
http://bugzilla.kernel.org/, product Drivers, component Network, and
letting us know the bug number so we can track it without forgetting
what has already been learned.

Hope that helps,
Jonathan

[1] http://thread.gmane.org/gmane.linux.network/219101