From: John Fastabend <john.r.fastabend@intel.com>
To: jhs@mojatatu.com, shemminger@vyatta.com,
bhutchings@solarflare.com, roprabhu@cisco.com,
davem@davemloft.net, jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, mst@redhat.com, chrisw@redhat.com,
gregory.v.rose@intel.com, kvm@vger.kernel.org, sri@us.ibm.com,
chealy@imsco-us.com
Subject: [net-next PATCH v0 0/5] Series short description
Date: Sun, 18 Mar 2012 23:51:45 -0700 [thread overview]
Message-ID: <20120319064719.10959.93361.stgit@jf-dev1-dcblab> (raw)
This series is a follow up to this thread:
http://www.spinics.net/lists/netdev/msg191360.html
This adds two NTF_XXX bits to signal if the PF_BRIDGE
netlink command should be parsed by the embedded bridge
or the SW bridge. The insight here is the SW bridge is
always the master device (NTF_MASTER) and the embedded
bridge is the lower device (NTF_LOWERDEV). Without either
flag set the command is parsed by the SW bridge to support
existing tooling.
To make this work correctly I added three new ndo ops
ndo_fdb_add
ndo_fdb_del
ndo_fdb_dump
to add, delete, and dump FDB entries. These operations
can be used by drivers to program embedded nics or by
software bridges. We have at least three SW bridge now
net/bridge, openvswitch, and macvlan. And three variants
of embedded bridges SR-IOV devices, multi-function devices
and Distributed Switch Architecture (DSA).
I think at least in this case adding netdevice ops is
the cleanest way to implement this. I thought about
notifier hooks and other methods but this seems to be
the simplest.
I've tested these three scenarios, embedded bridge only,
sw bridge only, and embedded bridge and SW bridge. These
are working on the Intel 82599 devices with this patch
series. I am also working on a patch for the macvlan
drivers. I'll submit that as an RFC shortly so far I
only have the passthru mode wired up.
Thanks to Stephen, Ben, and Jamal for bearing with me
and the feedback on the last round of patches.
As always any comments/feedback appreciated!
---
John Fastabend (5):
ixgbe: allow RAR table to be updated in promisc mode
ixgbe: enable FDB netdevice ops
net: add fdb generic dump routine
net: addr_list: add exclusive dev_uc_add
net: add generic PF_BRIDGE:RTM_XXX FDB hooks
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 80 +++++++++-
include/linux/neighbour.h | 3
include/linux/netdevice.h | 27 +++
include/linux/rtnetlink.h | 4 +
net/bridge/br_device.c | 3
net/bridge/br_fdb.c | 128 ++++------------
net/bridge/br_netlink.c | 12 --
net/bridge/br_private.h | 15 ++
net/core/dev_addr_lists.c | 19 ++
net/core/rtnetlink.c | 194 +++++++++++++++++++++++++
10 files changed, 363 insertions(+), 122 deletions(-)
--
Signature
next reply other threads:[~2012-03-19 7:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:51 John Fastabend [this message]
2012-03-19 6:51 ` [net-next PATCH v0 2/5] net: addr_list: add exclusive dev_uc_add John Fastabend
2012-03-25 13:07 ` Roopa Prabhu
2012-03-19 6:52 ` [net-next PATCH v0 3/5] net: add fdb generic dump routine John Fastabend
2012-03-25 13:09 ` Roopa Prabhu
2012-03-26 21:41 ` John Fastabend
2012-03-19 6:52 ` [net-next PATCH v0 4/5] ixgbe: enable FDB netdevice ops John Fastabend
2012-03-19 22:46 ` Jeff Kirsher
2012-03-19 6:52 ` [net-next PATCH v0 5/5] ixgbe: allow RAR table to be updated in promisc mode John Fastabend
2012-03-19 22:44 ` Jeff Kirsher
2012-03-19 22:38 ` [net-next PATCH v0 0/5] Series short description David Miller
2012-03-19 22:55 ` Stephen Hemminger
2012-03-20 0:27 ` John Fastabend
2012-03-20 0:35 ` David Miller
2012-03-20 2:49 ` John Fastabend
2012-03-20 2:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319064719.10959.93361.stgit@jf-dev1-dcblab \
--to=john.r.fastabend@intel.com \
--cc=bhutchings@solarflare.com \
--cc=chealy@imsco-us.com \
--cc=chrisw@redhat.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
--cc=shemminger@vyatta.com \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).