From: Steffen Klassert <steffen.klassert@secunet.com>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: davem@davemloft.net, eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment
Date: Mon, 19 Mar 2012 09:02:20 +0100 [thread overview]
Message-ID: <20120319080220.GA29891@secunet.com> (raw)
In-Reply-To: <1331888235-10368-1-git-send-email-gaofeng@cn.fujitsu.com>
On Fri, Mar 16, 2012 at 04:57:15PM +0800, Gao feng wrote:
> Since commit 299b0767(ipv6: Fix IPsec slowpath fragmentation problem)
> In func ip6_append_data,after call skb_put(skb, fraglen + dst_exthdrlen)
> the skb->len contains dst_exthdrlen,and we don't reduce dst_exthdrlen at last
> This will make fraggap>0 in next "while cycle",and cause the size of skb incorrent
Good catch!
>
> Call skb_pull reduce skb->len before next "while cycle"
I think it would be better to just reserve headroom for
dst_exthdrlen instead of adding and removing data to/from
the skb.
next prev parent reply other threads:[~2012-03-19 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 8:57 [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment Gao feng
2012-03-17 4:58 ` David Miller
2012-03-19 8:02 ` Steffen Klassert [this message]
2012-03-19 21:21 ` David Miller
2012-03-20 1:09 ` Gao feng
2012-03-20 3:22 ` [PATCH v2] " Gao feng
2012-03-20 7:58 ` Steffen Klassert
2012-03-20 8:36 ` [PATCH v3] " Gao feng
2012-03-20 8:54 ` Steffen Klassert
2012-03-20 9:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319080220.GA29891@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).