From: Sam Ravnborg <sam@ravnborg.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: David Miller <davem@davemloft.net>,
xemul@openvz.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [PATCH] adjust __net_exit
Date: Mon, 19 Mar 2012 09:47:03 +0100 [thread overview]
Message-ID: <20120319084703.GA20897@merkur.ravnborg.org> (raw)
In-Reply-To: <4F66F8F70200007800079305@nat28.tlf.novell.com>
> >> > Using the (bogus and unused elsewhere)
> >> > __exit_refok to implement this is inefficient - any non-modular code
> >> > really can reside in __init (as non-modular __exit code is never used).
> > 2) fix up the bogus commit message
>
> Bogus in what way?
I fail to see that __exit_refok is bogus.
The name is not optimal - which is why is is deprecated.
Sam
next prev parent reply other threads:[~2012-03-19 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 9:37 [PATCH] adjust __net_exit Jan Beulich
2012-03-17 5:18 ` David Miller
2012-03-17 23:03 ` Sam Ravnborg
2012-03-19 0:41 ` Eric W. Biederman
2012-03-19 8:14 ` Jan Beulich
2012-03-19 8:47 ` Sam Ravnborg [this message]
2012-03-19 9:09 ` Jan Beulich
2012-03-20 2:17 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319084703.GA20897@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=JBeulich@suse.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).