From: David Miller <davem@davemloft.net>
To: nick.jones@network-box.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics
Date: Tue, 20 Mar 2012 03:10:41 -0400 (EDT) [thread overview]
Message-ID: <20120320.031041.1349041584421003180.davem@davemloft.net> (raw)
In-Reply-To: <1332222481.25418.540.camel@nbnickhq4>
From: Nick Jones <nick.jones@network-box.com>
Date: Tue, 20 Mar 2012 13:48:01 +0800
> On Mon, 2012-03-19 at 18:04 -0400, David Miller wrote:
>> Furthermore, callers are only ready to handle NULL vs. non-NULL as
>> return values from this function. So this return value you are adding
>> will result in crashes.
>
> This one I did check. icmp6_dst_alloc returns error encoded pointers
> and all call sites test the return value with IS_ERR, I simply didn't
> understand the correct formatting macro, nor check the build properly.
> I think you got it mixed up with ip6_dst_alloc
Indeed you're right on this one. We changed this recently, in fact.
prev parent reply other threads:[~2012-03-20 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 15:41 [PATCH net-next v2] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics Nick Jones
2012-03-17 6:02 ` David Miller
2012-03-17 15:47 ` [PATCH net-next v3] " Nick Jones
2012-03-17 16:36 ` Eric Dumazet
2012-03-17 17:43 ` [PATCH net-next v4] " Nick Jones
2012-03-19 22:04 ` David Miller
2012-03-20 5:48 ` Nick Jones
2012-03-20 7:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320.031041.1349041584421003180.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nick.jones@network-box.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).