From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: bcrl@kvack.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix pppol2tp getsockname()
Date: Tue, 20 Mar 2012 16:13:27 -0400 (EDT) [thread overview]
Message-ID: <20120320.161327.1634186044606581815.davem@davemloft.net> (raw)
In-Reply-To: <4F6898DE.4020508@katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Tue, 20 Mar 2012 14:49:02 +0000
> On 20/03/12 13:57, Benjamin LaHaise wrote:
>> While testing L2TP functionality, I came across a bug in getsockname(). The
>> IP address returned within the pppol2tp_addr's addr memember was not being
>> set to the IP address in use. This bug is caused by using inet_sk() on the
>> wrong socket (the L2TP socket rather than the underlying UDP socket), and was
>> likely introduced during the addition of L2TPv3 support.
>>
>> Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
>
> Signed-off-by: James Chapman <jchapman@katalix.com>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2012-03-20 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 13:57 [PATCH] Fix pppol2tp getsockname() Benjamin LaHaise
2012-03-20 14:49 ` James Chapman
2012-03-20 20:13 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 3:15 Benjamin LaHaise
2012-03-19 21:50 ` David Miller
2012-03-20 11:49 ` James Chapman
2012-03-20 12:21 ` James Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320.161327.1634186044606581815.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@kvack.org \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).