From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: herbert@gondor.hengli.com.au, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fix napi_reuse_skb() skb reserve
Date: Wed, 21 Mar 2012 16:56:24 -0400 (EDT) [thread overview]
Message-ID: <20120321.165624.972276388107342047.davem@davemloft.net> (raw)
In-Reply-To: <1332349083.5330.49.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 21 Mar 2012 09:58:03 -0700
> napi->skb is allocated in napi_get_frags() using
> netdev_alloc_skb_ip_align(), with a reserve of NET_SKB_PAD +
> NET_IP_ALIGN bytes.
>
> However, when such skb is recycled in napi_reuse_skb(), it ends with a
> reserve of NET_IP_ALIGN which is suboptimal.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2012-03-21 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 16:58 [PATCH] net: fix napi_reuse_skb() skb reserve Eric Dumazet
2012-03-21 20:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321.165624.972276388107342047.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox