netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] enable automatic module loading for l2tp_ppp
@ 2012-03-21  0:01 Benjamin LaHaise
  2012-03-22  2:15 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Benjamin LaHaise @ 2012-03-21  0:01 UTC (permalink / raw)
  To: David S. Miller, James Chapman; +Cc: netdev

When L2TP is configured as a module, requests for L2TP sockets do not result
in the l2tp_ppp module being loaded.  Fix this by adding the appropriate
MODULE_ALIAS to be recognized by pppox's request_module() call.

Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
---
 net/l2tp/l2tp_ppp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c
index 9b07191..1addd9f 100644
--- a/net/l2tp/l2tp_ppp.c
+++ b/net/l2tp/l2tp_ppp.c
@@ -1845,3 +1845,4 @@ MODULE_AUTHOR("James Chapman <jchapman@katalix.com>");
 MODULE_DESCRIPTION("PPP over L2TP over UDP");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(PPPOL2TP_DRV_VERSION);
+MODULE_ALIAS("pppox-proto-" __stringify(PX_PROTO_OL2TP));
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] enable automatic module loading for l2tp_ppp
  2012-03-21  0:01 [PATCH] enable automatic module loading for l2tp_ppp Benjamin LaHaise
@ 2012-03-22  2:15 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-03-22  2:15 UTC (permalink / raw)
  To: bcrl; +Cc: jchapman, netdev

From: Benjamin LaHaise <bcrl@kvack.org>
Date: Tue, 20 Mar 2012 20:01:21 -0400

> When L2TP is configured as a module, requests for L2TP sockets do not result
> in the l2tp_ppp module being loaded.  Fix this by adding the appropriate
> MODULE_ALIAS to be recognized by pppox's request_module() call.
> 
> Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>

Please start adding proper subsystem/driver prefixes to your
Subject lines when submitting patches, I'm getting tired of
continually having to add them for you.  For this patch
"l2tp: " would have been appropriate.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-22  2:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-21  0:01 [PATCH] enable automatic module loading for l2tp_ppp Benjamin LaHaise
2012-03-22  2:15 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).