From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] sky2: override for PCI legacy power management Date: Wed, 21 Mar 2012 13:47:25 -0700 Message-ID: <20120321134725.222e9c07@nehalam.linuxnetplumber.net> References: <4F69BE2E.7070903@t-online.de> <20120321083205.360a7a3b@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Knut Petersen , "David S. Miller" , Linus Torvalds , arekm@maven.pl, Jared , dilieto@lineone.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Bjorn Helgaas Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 21 Mar 2012 14:22:01 -0600 Bjorn Helgaas wrote: > On Wed, Mar 21, 2012 at 9:32 AM, Stephen Hemminger > wrote: > > Some BIOS's don't setup power management correctly (what else is > > new) and don't allow use of PCI Express power control. Add a special > > exception module parameter to allow working around this issue. > > Based on slightly different patch by Knut Petersen. > > > > Reported-by: Arkadiusz Miskiewicz > > Signed-off-by: Stephen Hemminger > > Is there a problem report URL you can include here? > > It looks like this requires a user to figure out that he might be > suffering from this problem, then use this module parameter to work > around it. How would a user figure that out? Can we do it > automatically to save him the trouble? I am not a power management expert. Looks like a BIOS issue where the BIOS has configured the device to disable power management but the user wants to override that value. There is no method to determine when the BIOS is broken versus when the BIOS setting is correct and we should follow what it says.