From: David Miller <davem@davemloft.net>
To: venkat.x.venkatsubra@oracle.com
Cc: dan.carpenter@oracle.com, rds-devel@oss.oracle.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] RDS: use gfp flags from caller in conn_alloc()
Date: Thu, 22 Mar 2012 19:30:55 -0400 (EDT) [thread overview]
Message-ID: <20120322.193055.1929591502119781703.davem@davemloft.net> (raw)
In-Reply-To: <4F6B4316.5050508@oracle.com>
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Date: Thu, 22 Mar 2012 10:19:50 -0500
> On 3/22/2012 1:44 AM, Dan Carpenter wrote:
>> We should be using the gfp flags the caller specified here, instead of
>> GFP_KERNEL. I think this might be a bugfix, depending on the value of
>> "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in
>> rds_sendmsg(). Otherwise, it's just a cleanup.
>>
>> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Applied.
prev parent reply other threads:[~2012-03-22 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 6:44 [patch] RDS: use gfp flags from caller in conn_alloc() Dan Carpenter
2012-03-22 15:19 ` Venkat Venkatsubra
2012-03-22 23:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322.193055.1929591502119781703.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).