From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] usbnet: don't clear urb->dev in tx_complete Date: Thu, 22 Mar 2012 19:33:41 -0400 (EDT) Message-ID: <20120322.193341.331032344338370166.davem@davemloft.net> References: <1332422558-6633-1-git-send-email-tom.leiming@gmail.com> <20120322143607.GD19835@kroah.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org Return-path: In-Reply-To: <20120322143607.GD19835-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Greg Kroah-Hartman Date: Thu, 22 Mar 2012 07:36:07 -0700 > On Thu, Mar 22, 2012 at 09:22:38PM +0800, Ming Lei wrote: >> URB unlinking is always racing with its completion and tx_complete >> may be called before or during running usb_unlink_urb, so tx_complete >> must not clear urb->dev since it will be used in unlink path, >> otherwise invalid memory accesses or usb device leak may be caused >> inside usb_unlink_urb. >> >> Cc: stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org >> Cc: Alan Stern >> Cc: Oliver Neukum >> Signed-off-by: Ming Lei > > Acked-by: Greg Kroah-Hartman Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html