From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: NETDEV_ALIGN should match L1_CACHE_BYTES
Date: Thu, 22 Mar 2012 22:57:56 -0400 (EDT) [thread overview]
Message-ID: <20120322.225756.1072869324737577667.davem@davemloft.net> (raw)
In-Reply-To: <1332454760.6521.9.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 22 Mar 2012 15:19:20 -0700
> 32 bytes alignment had a meaning 10 years ago, it is not anymore the
> case.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
This value is supposed to conceptually be ARCH_DMA_MINALIGN.
Drivers, like the AMD Lance, would DMA in and out of the netdev
private struct. And as such DMA alignments have to be adhered
to.
There is way too much ISA and ancient crap out there to mess with
this, I think. Maybe we could set it to ARCH_DMA_MINALIGN (you'd need
to use a CPP test since architectures are not required to set this,
and use L1_CACHE_BYTES if it's not). But certainly we can't
unilaterally change it to L1_CACHE_BYTES.
prev parent reply other threads:[~2012-03-23 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 22:19 [PATCH] net: NETDEV_ALIGN should match L1_CACHE_BYTES Eric Dumazet
2012-03-23 2:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322.225756.1072869324737577667.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).