From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sandeep.kumar@freescale.com
Subject: Re: [PATCH] gianfar: Fix possible overrun and simplify interrupt name field creation
Date: Thu, 22 Mar 2012 23:34:26 -0400 (EDT) [thread overview]
Message-ID: <20120322.233426.51094636300419378.davem@davemloft.net> (raw)
In-Reply-To: <20120321.223457.641438956547942596.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 21 Mar 2012 22:34:57 -0400 (EDT)
> From: Joe Perches <joe@perches.com>
> Date: Sat, 17 Mar 2012 12:05:38 -0700
>
>> Space allocated for int_name_<foo> is unsufficient for
>> maximal device name, expand it.
>>
>> Code to create int_name_<foo> is obscure, simplify it
>> by using sprintf.
>>
>> Found by looking for unnecessary \ line continuations.
>> Uncompiled, untested.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> Can a gianfar expert please review and test this patch?
If you gianfar guys don't show a sign of life in the next 24 hours I'm
just going to apply Joe's patch as-is. I refuse to just let it rot in
patchwork like this.
And then you don't get to complain if his change breaks your driver
because I asked multiple times for testing and/or review.
next prev parent reply other threads:[~2012-03-23 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 19:05 [PATCH] gianfar: Fix possible overrun and simplify interrupt name field creation Joe Perches
2012-03-22 2:34 ` David Miller
2012-03-23 3:34 ` David Miller [this message]
2012-03-23 23:37 ` Paul Gortmaker
2012-03-25 17:10 ` [PATCH v2] " Paul Gortmaker
2012-03-25 17:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322.233426.51094636300419378.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sandeep.kumar@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).