From: Richard Cochran <richardcochran@gmail.com>
To: chetan loke <loke.chetan@gmail.com>
Cc: "Keller, Jacob E" <jacob.e.keller@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"john.stultz@linaro.org" <john.stultz@linaro.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH net V4 2/2] igb: offer a PTP Hardware Clock instead of the timecompare method
Date: Mon, 26 Mar 2012 17:27:30 +0200 [thread overview]
Message-ID: <20120326152730.GA10212@localhost.localdomain> (raw)
In-Reply-To: <CAAsGZS556o4iXtsWBzpiXxmv4isoZzw_h+RNv5eBMTGOsK905w@mail.gmail.com>
On Mon, Mar 26, 2012 at 11:07:40AM -0400, chetan loke wrote:
> On Sat, Mar 24, 2012 at 2:51 AM, Richard Cochran
> <richardcochran@gmail.com> wrote:
> > On Fri, Mar 23, 2012 at 03:39:08PM -0400, chetan loke wrote:
> >>
> >> So, how is it working today? Because we could have tx and rx
> >> completions on different CPUs. Is it not possible to have the
> >> following race today - between timecompare_update->timecompare_offset
> >> -> timecounter_readdelta of say Rx and timecounter_cyc2time from Tx?
> >
> > I works (in the igb) because of the spinlock. You know, that thing
> > that you are so against using.
> >
>
> I meant, was there a lock before the PHC functionality in igb?
There was no lock, and yes, it was a bug.
> >> How about rate limiting at the PHC class driver level? And then it
> >> will work across the board for all the adapters at the device level.
> >
> > No, don't go there. Enough bikeshedding already. If you have a serious
>
> can a user without root privileges use get/adj/set time ioctls for the
> PHC functionality?
Depends on how you set the character device node permissions.
Thanks,
Richard
next prev parent reply other threads:[~2012-03-26 15:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D3F292ADF945FB49B35E96C94C2061B916484EC4@nsmail.netscout.com>
2012-03-15 17:18 ` [PATCH net V4 2/2] igb: offer a PTP Hardware Clock instead of the timecompare method chetan loke
2012-03-16 6:55 ` Richard Cochran
2012-03-21 15:00 ` chetan loke
2012-03-21 16:08 ` Richard Cochran
2012-03-21 17:02 ` chetan loke
2012-03-22 7:00 ` Richard Cochran
2012-03-21 17:06 ` Keller, Jacob E
2012-03-22 7:09 ` Richard Cochran
2012-03-22 21:59 ` Keller, Jacob E
2012-03-23 6:05 ` Richard Cochran
2012-03-21 17:00 ` Richard Cochran
2012-03-21 17:09 ` Keller, Jacob E
2012-03-21 21:50 ` chetan loke
2012-03-22 6:41 ` Richard Cochran
2012-03-22 23:13 ` chetan loke
2012-03-23 5:59 ` Richard Cochran
2012-03-23 18:27 ` Keller, Jacob E
2012-03-23 19:39 ` chetan loke
2012-03-24 6:51 ` Richard Cochran
2012-03-26 15:07 ` chetan loke
2012-03-26 15:27 ` Richard Cochran [this message]
2012-03-26 17:11 ` chetan loke
2012-03-26 18:56 ` Keller, Jacob E
2012-03-26 19:32 ` chetan loke
2012-03-26 20:46 ` Keller, Jacob E
2012-03-27 18:05 ` Richard Cochran
2012-03-27 18:29 ` Keller, Jacob E
2012-03-27 18:43 ` chetan loke
2012-03-27 18:51 ` chetan loke
2012-03-27 20:58 ` Keller, Jacob E
2012-03-27 21:55 ` chetan loke
2012-03-29 23:08 ` Keller, Jacob E
2012-03-30 15:17 ` chetan loke
2012-03-27 15:33 ` Richard Cochran
2012-03-27 18:39 ` chetan loke
2012-03-26 20:51 ` Keller, Jacob E
2012-03-27 18:33 ` Richard Cochran
2012-01-21 16:03 [PATCH net V4 0/2] igb: ptp hardware clock Richard Cochran
2012-01-21 16:03 ` [PATCH net V4 2/2] igb: offer a PTP Hardware Clock instead of the timecompare method Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326152730.GA10212@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.ronciak@intel.com \
--cc=john.stultz@linaro.org \
--cc=loke.chetan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).