From: David Miller <davem@davemloft.net>
To: bcrl@kvack.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net/core] dev_forward_skb() should clear skb_iif
Date: Tue, 27 Mar 2012 17:37:07 -0400 (EDT) [thread overview]
Message-ID: <20120327.173707.226441470555050908.davem@davemloft.net> (raw)
In-Reply-To: <20120327162920.GB2367@kvack.org>
From: Benjamin LaHaise <bcrl@kvack.org>
Date: Tue, 27 Mar 2012 12:29:20 -0400
> While investigating another bug, I found that the code on the incoming path
> in __netif_receive_skb will only set skb->skb_iif if it is already 0. When
> dev_forward_skb() is used in the case of interfaces like veth, skb_iif may
> already have been set. Making dev_forward_skb() cause the packet to look
> more like a newly received packet would seem to the the correct behaviour
> here, as otherwise the wrong incoming interface can be reported for such a
> packet.
Same problems as your ipv4 multicast patch, I'm not applying this.
You must learn how to properly submit your changes, otherwise I
guarentee all of your work will hit the bit bucket.
prev parent reply other threads:[~2012-03-27 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 16:29 [PATCH net/core] dev_forward_skb() should clear skb_iif Benjamin LaHaise
2012-03-27 21:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327.173707.226441470555050908.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).